Fix pkg.group_info expanding dnf environment groups with multi-word member groups (fixes #60276)#69243
Open
ggiesen wants to merge 1 commit into
Open
Fix pkg.group_info expanding dnf environment groups with multi-word member groups (fixes #60276)#69243ggiesen wants to merge 1 commit into
ggiesen wants to merge 1 commit into
Conversation
When pkg.group_installed/pkg.group_info expands a dnf environment group (e.g. "Workstation"), it recurses into each member group using "@" + the group's display name. dnf cannot resolve "@" + a multi-word display name (e.g. "@common NetworkManager submodules") -- it warns on stderr and prints nothing to stdout -- so group_info raised "Group '@...' not found" and the whole group install failed (saltstack#60276). Fall back to the bare group name when the @-prefixed lookup fails, so multi-word member groups expand. The @ form is still tried first to keep disambiguating single-token group ids. This is dnf4 (EL8/9/10); dnf5 group handling is a separate, larger concern.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes
pkg.group_installed/pkg.group_infofailing to expand a dnf environment group whose member groups have multi-word display names.When
group_infoexpands an environment group (e.g.Workstation), it recurses into each member group as"@" + <display name>. dnf cannot resolve"@"+ a multi-word name (e.g.@Common NetworkManager submodules) -- it warns on stderr and prints nothing to stdout -- sogroup_inforaisedGroup '@Common NetworkManager submodules' not foundand the whole group install failed.The fix tries the
@form first (to keep disambiguating single-token group ids, the original reason for the prefix) and falls back to the bare group name when that lookup fails, so multi-word member groups expand.What issues does this PR fix or reference?
Fixes #60276
Previous Behavior
Installing an environment group (
Workstation) on RHEL/AlmaLinux 8/9/10 failed withGroup '@Common NetworkManager submodules' not found.New Behavior
The member group is resolved by its bare name when the
@-prefixed lookup fails; the environment group expands and installs.Scope: dnf4 only
Verified the bug and the fix against real dnf on AlmaLinux 8 (dnf 4.7), 9 (4.14) and 10 (4.20) -- all current EL releases ship dnf4, so this covers EL8/9/10. dnf5 (Fedora, and likely a future EL) changed the group subcommands and output format enough that yumpkg's group handling needs separate work; that is out of scope here and is documented on #60276.
Tests
Added a unit test (
tests/pytests/unit/modules/test_yumpkg.py) reproducing an environment group with a multi-word member group. It fails with the exactGroup '@...' not founderror without the fix and passes with it.Merge requirements satisfied?
changelog/60276.fixed.md)Commits signed with GPG?
No