Repository navigation
fix(compiler): preserve nested None defaults (#103) - #115
Open
amazingjoe wants to merge 1 commit into
Open
amazingjoe wants to merge 1 commit into
amazingjoe wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Preserve nested None values as JSON null in compiled variable defaults, retaining object properties, list lengths, and element positions.
Why
extractExpressionValue() did not handle NoneLiteral, so it returned undefined. Recursive dictionary extraction then omitted those properties, and list extraction filtered out those elements without emitting diagnostics.
Fixes #103
How
Recognize NoneLiteral in extractExpressionValue() and return JavaScript null. Existing dictionary and list extraction already preserve null values.
The production change is confined to packages/compiler/src/ast-helpers.ts. Regression tests were added to two existing compiler test files.
packages/compiler/src/ast-helpers.tsNoneLiteraltonull, preserving nested object properties and list elements.packages/compiler/test/ast-helpers.test.tsshould extract NoneLiteral as JSON nullpackages/compiler/test/state-variables.test.tsshould preserve 'object properties containing None' in defaultspackages/compiler/test/state-variables.test.tsshould preserve 'list positions containing None' in defaultspackages/compiler/test/state-variables.test.tsshould preserve 'None inside an object containing a list and another object' in defaultspackages/compiler/test/state-variables.test.tsshould preserve 'None inside a list containing another list and an object' in defaultspackages/compiler/test/state-variables.test.tsshould preserve 'falsy values inside objects and lists' in defaultsTest Plan
Added six tests using the existing Vitest framework:
Existing tests and assertions were retained, including standalone None omission coverage.
The exact issue reproduction now produces the expected defaults:
The falsy-value control remains unchanged. The reproduction exited with status 1 before the fix and 0 afterward. Parsing succeeded and schema, lint, and compiler diagnostics were empty in both runs.
Additional validation:
Repository-wide pnpm lint && pnpm typecheck has not been run.
Checklist