Repository navigation
fix(compiler): preserve nested empty object defaults (#101) - #114
Open
amazingjoe wants to merge 1 commit into
Open
amazingjoe wants to merge 1 commit into
amazingjoe wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Preserve nested empty objects in compiled variable defaults, retaining object properties and list lengths and element positions.
Why
extractDictExpression()returnedundefinedfor empty dictionaries. Recursive extraction then omitted those values from parent objects and filtered them out of lists, without emitting diagnostics.Fixes #101
How
Return the extracted dictionary even when it is empty. Missing/non-dictionary inputs and unsupported expressions continue to return
undefined. Existing dictionary-key prototype protection is preserved.The production change is confined to
packages/compiler/src/ast-helpers.ts. Regression tests were added to four existing compiler test files.Test Plan
Added 16 tests using the existing Vitest framework:
Existing test assertions were retained. Here is what the latest regression test suite looks like before/after the fixes.
The original issue reproduction now preserves both defaults:
payload{"full":{"n":1}}{"empty":{},"full":{"n":1}}items[{"n":1}][{},{"n":1},{}]The reproduction exited with status 1 before the fix and 0 afterward. Compiler diagnostics were empty in both runs.
pnpm test)pnpm lint && pnpm typecheck)Checklist