Consume verified Notion snapshot context#196
Merged
Merged
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 55b2e55976
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Allow receipt-backed portfolio generation to consume an explicitly configured Notion snapshot when the direct Notion API path is unavailable.
Why
The scheduled producer had a fresh schema-v2 snapshot but still carried forward stale Notion context because portfolio truth only attempted the direct API loader.
Review Of What Was Built
GHRA_NOTION_SNAPSHOT_PATHas an explicit producer input.Cleanup Review
No generated outputs, schemas, or unrelated producer behavior changed. Stale or unverified snapshots remain no-write/unavailable inputs.
Verification Summary
uv run pytest -q tests/test_portfolio_truth.py tests/test_project_registry.py tests/test_operator_os_seam_linter.py— 129 passed.uv run ruff check .— passed.git diff --check— passed.Shipped Summary
The branch can use a fresh, independently verified Notion snapshot without silently treating arbitrary local JSON as live context.
Next Phase
Wire the canonical scheduled producer to the explicit snapshot path, regenerate from the merged commit, and verify
inputs.notion.mode=livewith no carry-forward.Remaining Roadmap
Reconcile BridgeDB, close the three authorized SHIPPED rows, then rotate and verify the recovery anchor.