Repository navigation
fix(add): accept any list sharing the requested title in the read-back - #383
Merged
Merged
Conversation
Fixes from a /code-review high pass over main since v0.9.0: - add and import accept a new item in any open project or area that shares the requested list title, since which one Things picks is unknown (db.ListTitleShared) - an import item whose list attribute holds a uuid is left unchecked, because Things matches list by title and files it in the Inbox - project add trims the area title before folding the shared-title key - checklist reads order by index then uuid, so the edit read-back's row-by-row compare is stable - project add reuses the areas projectAreaID already read - update hands the child process d.in() instead of os.Stdin - the row-number block in resolveTask only runs for row refs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes from a `/code-review high` pass over main since v0.9.0. The two serious ones are false failures in the add/import read-back: the item is created, but the CLI exits non-zero with "do not retry blindly".
Tests: `TestAddSharedListTitleFitsEither` (3 of its 5 cases fail without the fix), plus `uuidAsList` and `sharedAreaTitle` cases in `TestImportCreatedChecksDestination`. `make test` and `make lint` pass after rebasing onto 63a3f9a. Not checked in real Things.
Docs: `docs/content/agents.md` and `internal/skill/SKILL.md` describe both read-back changes.