feat(nats source): backport end-to-end acknowledgements to v0.58 - #1
Closed
ryanbrooks-tomtom wants to merge 8 commits into
Closed
ryanbrooks-tomtom wants to merge 8 commits into
ryanbrooks-tomtom wants to merge 8 commits into
Conversation
Co-authored-by: Ryan Brooks <ryanbrooks-tomtom@users.noreply.github.com>
Co-authored-by: Ryan Brooks <ryanbrooks-tomtom@users.noreply.github.com>
Co-authored-by: Ryan Brooks <ryanbrooks-tomtom@users.noreply.github.com>
Co-authored-by: Ryan Brooks <ryanbrooks-tomtom@users.noreply.github.com>
Co-authored-by: Ryan Brooks <ryanbrooks-tomtom@users.noreply.github.com>
Co-authored-by: Ryan Brooks <ryanbrooks-tomtom@users.noreply.github.com>
Co-authored-by: Ryan Brooks <ryanbrooks-tomtom@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Personal-use backport of NATS source end-to-end acknowledgement support to the
v0.58release branch.This replays only the five commits from vectordotdev#26397 and adapts them to the v0.58 NATS stream architecture without including later reconnect changes from
master.References
Related: vectordotdev#26397
Vector configuration
NATS JetStream integration-test configuration.
How did you test this PR?
make fmtFEATURES="sources-nats" make check-clippycargo test --workspace --no-default-features --features "sources-nats" sources::nats::source::tests— 4 passedThe integration tests requiring a running NATS service were not executed in this environment.
Is this a breaking change?
Does this PR include user facing changes?
no-changeloglabel to this PR.Contributor Guidelines
@vectordotdev/vectorto reach out to us regarding this PR.