fix(player-core): show hotspot after seeking back to a video step - #5
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2
Problem
PhotoLayerfiredonReadyonly whensrcchanged. When playback went video → photo, the user seeked back to the video step, and it played into the same photo again,photo.srcwas unchanged. The decode effect never re-ran, sohandlePhotoReadynever swapped the layers or revealed the hotspot.Fix
PhotoLayertakes arenderIdprop. Its decode effect re-runs whensrcorrenderIdchanges, and still cancels superseded decodes.Playerbumpsphoto.renderIdon every photo step render.Tests
Player.test.tsfor a demo with a video step and a photo step that has a hotspot: advance, seek back, advance again. The hotspot has to show both times. It fails without the fix.check-types, Biome andsize(29.07 KB / 35 KB).