feat(extension): redesign the toolbar popup - #10
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Redesign of the toolbar popup, following the pattern of Arcade and Supademo: an anchored popup that closes as soon as recording starts.
Idle
prefers-reduced-motion.chrome://, other extensions, the Web Store) get an explanation and a disabled CTA, instead of failing silently.Recording
Pure helpers (
isRecordableUrl,displayHost,formatElapsed,formatRelativeTime) live inentrypoints/popup/core/format.tswith unit tests. Data loading is inhooks/use-popup-data.ts.lib/db.tsgainslistRecentRecordings().Fix:
cn()dropped text colorstailwind-merge didn't know our custom type scale, so it read
text-ui/text-2xsas text colors and merged away the real one. This is why the lime CTA showed white text.cn()now registers them as font sizes. This also affects the editor: anywhere these classes were combined with a text color, either the color or the size was being lost.Test plan
pnpm --filter @rustrak/openshowcase-extension test(128 passing)check-types,biome cichrome.*in light/dark mode, in the idle, recording and unrecordable-page states.output/chrome-mv3unpacked in Chrome and record a real flowcn()fix