fix: ignore empty lifecycle action containers - #244
Merged
Merged
Conversation
16 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #240 and rustfs/rustfs#8036, rebased on the latest
main.Expiration: {}andNoncurrentVersionExpiration: {}containers instead of rendering fake actions.Validation
pnpm test:run— 605 tests passed.pnpm type-check— passed.pnpm lint— passed.pnpm format:check— passed.git diff --check— passed.Screenshots
Backend note
MinIO rejects an empty
<Expiration/>during lifecycle validation. RustFS currently checks only whether the expiration object is present, so the backend should separately validate Days/Date/ExpiredObjectDeleteMarker. This PR fixes Console projection; backend execution remains unchanged.