Repository navigation
Conversation
Use the current concurrency test name so the exact smoke filter executes one test instead of silently accepting an empty match. Validation: all 17 HTTPS smoke cases executed and passed, plus fmt, clippy, 1,988 workspace tests, 71 HTTP integration cases, 10 S3 golden cases, and 13 Python script tests. Independent review found no blockers.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related failure
Restores the scheduled Integration Tests run, where the three
--enc-s3cases returned HTTP 500 and prevented the S3 golden step from running.Root cause and solution
RUSTFS_SSE_S3_MASTER_KEYwhen no KMS is configured. Neither CI container launch supplied it. Add an explicitly public, test-only fixture and keep the local Compose and documented Docker setup consistent.bucket_operations, rb's v3bucket_remove, and unversioned stat'sname. Assert exact bucket identity, outcomes, completion stage, object name, and size.No production command behavior, schema, dependency, or real credential changes.
Validation
Validated with Rust 1.99.1 and the official RustFS 1.0.0-beta.10 Linux binary, whose release archive SHA-256 was verified.
cargo fmt --all --check: passed.cargo clippy --locked --workspace --all-targets -- -D warnings: passed.cargo test --locked --workspace: 1,988 passed, 2 existing ignored. Local mock-server tests used an offline run with proxy environment variables unset.cargo test --locked --package rustfs-cli --test golden --features golden,integration -- --test-threads=1: 10 passed.git diff --checkpassed.Docker is unavailable in the local validation environment. PR CI will exercise the actual containers; the full-target GitHub Actions job still runs on schedule or manual dispatch, not on an ordinary PR event.
CI status for 3a5f8ec
pin-utils 0.1.1,RUSTSEC-2026-0441(unmaintained), through AWS Smithy.Cargo.lockis byte-for-byte identical to the base. This PR does not suppress the advisory.