fix: harden CLI safety, S3 transport, and release workflows#253
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This came out of a repo-wide adversarial review rather than a single issue.
Related issue: none.
Breaking changes
BREAKING: unsupported command options now return an explicit error instead of being silently ignored. Bucket and prefix removal also requires
--recursive, and SigV2 alias configuration is rejected because the transport only supports SigV4.Validation
cargo fmt --all --checkcargo clippy --workspace --all-targets --locked -- -D warningscargo test --workspace --locked --quietcargo test --package rustfs-cli --test golden --features golden --lockedcargo deny check advisoriesRUSTDOCFLAGS='-D warnings' cargo doc --workspace --no-deps --lockedcargo +1.92.0 check --workspace --all-targets --lockedProtected schema, config, exit-code, and command-reference files are unchanged. Full external S3 and Docker runtime coverage remains in CI.