Repository navigation
fix(test): make VM failure reruns deterministic - #137
Merged
Merged
Conversation
There was a problem hiding this comment.
🟡 Changes recommended
Live setup aborts on an unbound remote RUN_ID, and storage monitoring can continue writing after a failed capacity measurement.
4 open issues
What changed in this PR
This PR improves VM validation rerun reliability in the RustFS test harness without changing product code or canonical assertions.
Changes:
- Adds security log capture, data-disk package staging, and clearer logger failure propagation.
- Adds performance timeouts and failure cutoffs, plus configurable pool-fill rounds and expanded diagnostics.
- Updates regression tests, workflow registry checks, and permission fixtures.
| File | Description |
|---|---|
validation-migration-review.json |
Refreshes hashes for modified validation files. |
test_validation_pool.py |
Checks missing-service handling and file-log collection. |
test_validation_heal_persistence_mrf.py |
Makes fixture permissions independent of umask. |
test_rustfs_tier.sh |
Adjusts logger-crash regression tests. |
test_rustfs_table.py |
Checks data-backed package staging and retries. |
test_rustfs_security.py |
Verifies dry-run log capture. |
test_rustfs_pool_expand.sh |
Tests service handling, error classification, and multiple rounds. |
test_rustfs_performance_testing.py |
Adds timeout and failure-cutoff coverage. |
scripts/validation_registry.py |
Checks declared events rather than comment text. |
scripts/validation_pool/run_case.sh |
Handles absent services and collects rolling logs. |
scripts/test_functional_dispatch.py |
Tests retired event names in comments. |
rustfs-tier-test.sh |
Preserves logger signal-exit statuses. |
rustfs-table-test.sh |
Stages packages on the data disk with download retries. |
rustfs-security-test.sh |
Adds --log-file output capture. |
rustfs_pool_expand.sh |
Adds configurable fill rounds and broader error detection. |
rustfs_performance_testing.sh |
Adds round timeouts and consecutive-failure cutoffs. |
rustfs_performance_test.sh |
Exposes and forwards benchmark limits. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Summary
--log-filesupport to the security suite and preserve its full output in CI artifacts.umask.Verification
python3 -m unittest -v test_rustfs_security test_rustfs_table test_sensitive_diagnostics test_rustfs_performance_testingpython3 -m unittest -v test_validation_poolpython3 -m unittest -v test_validation_migration.ImplementationReviewTestpython3 scripts/validation_registry.py checkcd scripts && python3 -m unittest -v test_functional_dispatchbash test_rustfs_tier.shbash test_rustfs_pool_expand.shbash -nacross all shell scriptsThe VM live rerun is the next verification step. Product failures from the previous run remain out of scope for this PR.