Upgrade ego-tree to 0.11.0 and html5ever to 0.37.1#300
Merged
Conversation
Member
cfvescovo
commented
Jan 23, 2026
- Bump ego-tree from 0.10.0 to 0.11.0
- Bump html5ever from 0.36.0 to 0.37.1
- Bump tendril from 0.4.3 to 0.5.0 (required by html5ever 0.37.1)
- Implement clone_subtree() method for TreeSink trait
- Bump ego-tree from 0.10.0 to 0.11.0 - Bump html5ever from 0.36.0 to 0.37.1 - Bump tendril from 0.4.3 to 0.5.0 (required by html5ever 0.37.1) - Implement clone_subtree() method for TreeSink trait
There was a problem hiding this comment.
Pull request overview
This PR upgrades the HTML parsing stack (ego-tree, html5ever, tendril) and updates the HtmlTreeSink to implement the new TreeSink::clone_subtree API, along with minor logging modernizations.
Changes:
- Bump
ego-treeto0.11.0,html5everto0.37.1, andtendrilto0.5.0to keep dependencies current and compatible. - Implement
TreeSink::clone_subtreeforHtmlTreeSinkby delegating toego_tree’sclone_subtreeand returning the new node’sNodeId. - Modernize error printing in
scraper/src/main.rsto use captured format arguments.
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| scraper/src/main.rs | Switches eprintln! calls to captured-format syntax, preserving behavior while updating style. |
| scraper/src/html/tree_sink.rs | Adds a clone_subtree implementation that clones a subtree via ego_tree and returns the cloned root’s handle, matching the updated TreeSink trait. |
| scraper/Cargo.toml | Updates direct dependency versions for ego-tree, html5ever, and tendril to the new releases. |
| Cargo.lock | Regenerates lockfile to reflect updated crate versions and transitive dependency changes. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.