Create GPU notification group#2337
Merged
jieyouxu merged 1 commit intorust-lang:mainfrom Mar 20, 2026
Merged
Conversation
lqd
reviewed
Mar 19, 2026
apiraino
force-pushed
the
create-gpu-target
branch
from
f099a5b to
a6f79ec
Compare
Member
|
@LegNeato do you want to be added to this as well? |
jieyouxu
requested changes
Mar 19, 2026
jieyouxu
added
needs-team-repo-admin-review
apiraino
force-pushed
the
create-gpu-target
branch
from
a6f79ec to
dfdf948
Compare
jieyouxu
added
S-waiting-on-review
jieyouxu
previously approved these changes
Mar 20, 2026
Member
There was a problem hiding this comment.
Still need people/ entries for
Error: rust_team::validate] validation error: Person Firestar99 not found
Error: rust_team::validate] validation error: Person Flakebi not found
Error: rust_team::validate] validation error: Person kjetilkjeka not found
Error: rust_team::validate] validation error: Person legneato not found
Error: rust_team::validate] validation error: person `Firestar99` is member of team `gpu-target` but doesn't exist
Error: rust_team::validate] validation error: person `Flakebi` is member of team `gpu-target` but doesn't exist
Error: rust_team::validate] validation error: person `kjetilkjeka` is member of team `gpu-target` but doesn't exist
Error: rust_team::validate] validation error: person `legneato` is member of team `gpu-target` but doesn't exist
Yes please (looks like I am there?) |
|
Thanks for doing this! Maybe @kulst wants to be added as well? |
apiraino
force-pushed
the
create-gpu-target
branch
from
dfdf948 to
d17a76b
Compare
Dry-run check results |
RalfJung
reviewed
Apr 15, 2026
| "Sa4dUs", | ||
| "ZuseZ4", | ||
| # other members for T-compiler | ||
| "RalfJung", |
Member
There was a problem hiding this comment.
Please don't add people without their consent. :)
Contributor
Author
There was a problem hiding this comment.
@RalfJung I'm sorry!
Then I must have misunderstood this comment from Jubilee and (the following one from you).
Was the comment from Jubilee a slightly convoluted way to just say "don't add Ralf to this group"?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As per discussion on Zulip.
@Kobzol before sending pings to everyone mentioned in this new file, can you let me know if this looks correct (never created a notification group before).
Thanks :)