Repository navigation
Don't use a shared reference in MsgHdrMut - #674
Merged
Merged
Conversation
Thomasdezeeuw
force-pushed
the
thomas/673
branch
from
October 6, 2026 08:24
5d1dd6a to
f0ce017
Compare
Returns a raw mutable pointer to the address.
Thomasdezeeuw
force-pushed
the
thomas/673
branch
from
October 6, 2026 14:23
f0ce017 to
6e677b0
Compare
Darksonn
reviewed
Oct 10, 2026
|
|
||
| /// Returns a raw mutable pointer to the address. | ||
| pub fn as_mut_ptr(&mut self) -> *mut SockAddrStorage { | ||
| &mut self.storage as *mut sockaddr_storage as *mut SockAddrStorage |
Member
There was a problem hiding this comment.
Suggested change
| &mut self.storage as *mut sockaddr_storage as *mut SockAddrStorage | |
| &raw mut self.storage as *mut SockAddrStorage |
or if this doesn't work on MSRV:
Suggested change
| &mut self.storage as *mut sockaddr_storage as *mut SockAddrStorage | |
| addr_of_mut!(self.storage) as *mut SockAddrStorage |
Collaborator
Author
There was a problem hiding this comment.
I tried the nicer way, but the MSRV is too low. The code matches the as_ptr function.
This way the raw pointer is not invalidated.
Darksonn
approved these changes
Oct 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because we used set_msghdr_name, which uses a reference to SockAddr we
broke the aliasing rules. See #673 for more details. To fix this use raw pointers instead.
Also adds SockAddr::as_mut_ptr, which I needed to do this and since it's quite useful I made it public.
Fixes #673