Repository navigation
refactor(download): cleanup resumption logic of partial download - #5185
Merged
rami3l merged 2 commits intoNov 2, 2026
Merged
Conversation
rami3l
force-pushed
the
refactor/download-interrupt-cleanup
branch
from
November 2, 2026 17:07
1d3da32 to
965c63c
Compare
rami3l
marked this pull request as ready for review
November 2, 2026 17:11
…tial()` The actual intention of this function is whether a `Error` should allow keeping a partial download, so it's better to name it accordingly.
rami3l
force-pushed
the
refactor/download-interrupt-cleanup
branch
from
November 2, 2026 17:11
965c63c to
d1db797
Compare
djc
approved these changes
Nov 2, 2026
Contributor
|
Thanks, sorry for forgetting about this followup! |
Member
Author
|
@djc No worries! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch includes some minor follow-up changes to #5177.