Skip to content

ci: remove redundant cargo check steps #5074

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ChrisDenton merged 1 commit into from
Sep 13, 2026
+6 −46
Merged

ci: remove redundant cargo check steps #5074

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 4 additions & 33 deletions .github/workflows/ci.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,20 +158,11 @@ jobs:
TARGET: ${{ matrix.target }}
BUILD_PROFILE: ${{ matrix.mode }}
run: bash ci/run.bash
- name: Run cargo check
if: matrix.mode != 'release'
env:
TARGET: ${{ matrix.target }}
# os-specific code leads to lints escaping if we only run this in one target
run: |
cargo check --all --all-targets --features test
git -c core.quotePath=false ls-files -- '*.rs' | ForEach-Object {
(Get-Item -LiteralPath $_).LastWriteTime = Get-Date
}
- name: Run cargo clippy
if: matrix.mode != 'release' && matrix.mingwdir == ''
env:
TARGET: ${{ matrix.target }}
# os-specific code leads to lints escaping if we only run this in one target
run: |
rustup component add clippy
cargo clippy --all-targets --all-features -- -D warnings
Expand Down Expand Up @@ -358,20 +349,11 @@ jobs:
TARGET: ${{ matrix.target }}
BUILD_PROFILE: ${{ matrix.mode }}
run: bash ci/run.bash
- name: Run cargo check
if: matrix.mode != 'release'
env:
TARGET: ${{ matrix.target }}
# os-specific code leads to lints escaping if we only run this in one target
run: |
cargo check --all --all-targets --features test
git -c core.quotePath=false ls-files -- '*.rs' | ForEach-Object {
(Get-Item -LiteralPath $_).LastWriteTime = Get-Date
}
- name: Run cargo clippy
if: matrix.mode != 'release' && matrix.mingwdir == ''
env:
TARGET: ${{ matrix.target }}
# os-specific code leads to lints escaping if we only run this in one target
run: |
rustup component add clippy
cargo clippy --all-targets --all-features -- -D warnings
Expand Down Expand Up @@ -564,20 +546,11 @@ jobs:
TARGET: ${{ matrix.target }}
BUILD_PROFILE: ${{ matrix.mode }}
run: bash ci/run.bash
- name: Run cargo check
if: matrix.mode != 'release'
env:
TARGET: ${{ matrix.target }}
# os-specific code leads to lints escaping if we only run this in one target
run: |
cargo check --all --all-targets --features test
git -c core.quotePath=false ls-files -- '*.rs' | ForEach-Object {
(Get-Item -LiteralPath $_).LastWriteTime = Get-Date
}
- name: Run cargo clippy
if: matrix.mode != 'release' && matrix.mingwdir == ''
env:
TARGET: ${{ matrix.target }}
# os-specific code leads to lints escaping if we only run this in one target
run: |
rustup component add clippy
cargo clippy --all-targets --all-features -- -D warnings
Expand Down Expand Up @@ -1580,10 +1553,8 @@ jobs:
run: |
rustup toolchain install nightly --profile=minimal -c=rustfmt
cargo +nightly xfmt --check
- name: Run cargo check and clippy
- name: Run cargo clippy
run: |
cargo check --all --all-targets --features test
git ls-files -- '*.rs' | xargs touch
cargo clippy --all-targets --all-features -- -D warnings
# This is ci/actions-templates/all-features-template.yaml
# Do not edit this file in .github/workflows
Expand Down
4 changes: 1 addition & 3 deletions ci/actions-templates/centos-fmt-clippy-template.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,8 +80,6 @@ jobs: # skip-all
run: |
rustup toolchain install nightly --profile=minimal -c=rustfmt
cargo +nightly xfmt --check
- name: Run cargo check and clippy
- name: Run cargo clippy
run: |
cargo check --all --all-targets --features test
git ls-files -- '*.rs' | xargs touch
cargo clippy --all-targets --all-features -- -D warnings
11 changes: 1 addition & 10 deletions ci/actions-templates/windows-builds-template.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,20 +149,11 @@ jobs: # skip-main skip-pr skip-stable
TARGET: ${{ matrix.target }}
BUILD_PROFILE: ${{ matrix.mode }}
run: bash ci/run.bash
- name: Run cargo check
if: matrix.mode != 'release'
env:
TARGET: ${{ matrix.target }}
# os-specific code leads to lints escaping if we only run this in one target
run: |
cargo check --all --all-targets --features test
git -c core.quotePath=false ls-files -- '*.rs' | ForEach-Object {
(Get-Item -LiteralPath $_).LastWriteTime = Get-Date
}
- name: Run cargo clippy
if: matrix.mode != 'release' && matrix.mingwdir == ''
env:
TARGET: ${{ matrix.target }}
# os-specific code leads to lints escaping if we only run this in one target
run: |
rustup component add clippy
cargo clippy --all-targets --all-features -- -D warnings
Expand Down
Loading