ci(windows): only generate hash for files in prepare-deploy.ps1 - #5072
Merged
Merged
Conversation
Member
Author
|
Fix verified by the before/after comparison from: BeforeRun .\ci\prepare-deploy.ps1
Directory: D:\a\rustup\rustup\dist
Mode LastWriteTime Length Name
---- ------------- ------ ----
d----- 9/10/2026 11:13 AM x86_64-pc-windows-msvc
Directory: D:\a\rustup\rustup\dist\x86_64-pc-windows-msvc
Mode LastWriteTime Length Name
---- ------------- ------ ----
-a---- 9/10/2026 11:13 AM 12339712 rustup-init.exe
-a---- 9/10/2026 11:13 AM 65 rustup-init.exe.sha256
-a---- 9/10/2026 11:13 AM 12339712 rustup-setup.exe
-a---- 9/10/2026 11:13 AM 65 rustup-setup.exe.sha256 https://github.com/rust-lang/rustup/actions/runs/34469571059/job/102846049919 AfterRun .\ci\prepare-deploy.ps1
Directory: D:\a\rustup\rustup\dist
Mode LastWriteTime Length Name
---- ------------- ------ ----
d---- 9/12/2026 8:06 AM x86_64-pc-windows-msvc
Directory: D:\a\rustup\rustup\dist\x86_64-pc-windows-msvc
Mode LastWriteTime Length Name
---- ------------- ------ ----
-a--- 9/12/2026 8:06 AM 12339712 rustup-init.exe
-a--- 9/12/2026 8:06 AM 65 rustup-init.exe.sha256
-a--- 9/12/2026 8:06 AM 12339712 rustup-setup.exe
-a--- 9/12/2026 8:06 AM 65 rustup-setup.exe.sha256https://github.com/rust-lang/rustup/actions/runs/34682121072/job/103522556812?pr=5072 |
rami3l
force-pushed
the
ci/early-exit-prepare-pwsh
branch
from
September 12, 2026 08:28
1b1e57c to
848da40
Compare
rami3l
marked this pull request as ready for review
September 12, 2026 08:29
Contributor
|
LGTM |
djc
approved these changes
Sep 12, 2026
Member
|
Thanks for following up on this! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is a loophole that has been exposed by #5070 when switching to short-circuiting
pwshfor allpowershell/pwshscripts, as suggested by @ChrisDenton in #5070 (comment).Originally, the filtering logic for
*.sha256generation inprepare-deploy.ps1didn't consider the fact that only files can be hashed. However, since the hashing of directories (which always fails) was silently skipped, the issue never became a CI error until today.This patch fixes that by mirroring
prepare-deploy.bash'sfind ... -type fmore closely so that we only generate hashes for files.cc @Cloud0310 for review.