Skip to content

Fix Windows CI's Powershell not propagate error by default #5070

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rami3l merged 3 commits into from
Sep 12, 2026
+28 −28
Merged

Fix Windows CI's Powershell not propagate error by default #5070

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8926865
fix(ci): propagate Windows check and clippy failures
Cloud0310 Sep 11, 2026
846bce5
refactor(ci): replace xargs touch with native PowerShell
Cloud0310 Sep 12, 2026
b3fc074
refactor(ci): use Powershell 7 solely for Windows actions
Cloud0310 Sep 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 21 additions & 21 deletions .github/workflows/ci.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,10 @@ jobs:
build-windows-pr: # job-name skip-main skip-stable
runs-on: ${{ matrix.os || 'windows-latest' }}
if: ${{ contains(fromJSON('["pull_request", "merge_group"]'), github.event_name) }} # skip-main skip-stable
defaults:
run:
# Keep Git's Perl out of the OpenSSL build and stop on native command failures.
shell: pwsh -Command $ErrorActionPreference='stop'; $PSNativeCommandUseErrorActionPreference=$true; & '{0}'
env:
RUSTFLAGS: -Ctarget-feature=+crt-static
RUST_MIN_STACK: 16777216
Expand Down Expand Up @@ -73,7 +77,6 @@ jobs:
run: |
New-Item "${env:USERPROFILE}\.cargo\registry" -ItemType Directory -Force
New-Item "${env:USERPROFILE}\.cargo\git" -ItemType Directory -Force
shell: powershell
- name: Install NASM
# Building `aws-lc-rs` for Windows MSVC depends on `NASM`.
# See: https://aws.github.io/aws-lc-rs/requirements/windows.html
Expand All @@ -85,7 +88,6 @@ jobs:
with:
architecture: ${{ matrix.arch }}
- name: Install llvm-mingw
shell: powershell
if: matrix.llvm_mingw_version != ''
run: |
$version = "${{ matrix.llvm_mingw_version }}"
Expand All @@ -106,7 +108,6 @@ jobs:
"CC_${targetEnvUpper}=${{ matrix.gcc }}" | Out-File -Append -FilePath $env:GITHUB_ENV -Encoding utf8
"CARGO_TARGET_${targetEnvUpper}_LINKER=${{ matrix.gcc }}" | Out-File -Append -FilePath $env:GITHUB_ENV -Encoding utf8
- name: Verify mingw gcc installation
shell: powershell
if: matrix.gcc != ''
run: |
Get-Command ${{ matrix.gcc }}
Expand Down Expand Up @@ -147,10 +148,8 @@ jobs:
Invoke-WebRequest "https://win.rustup.rs/${env:RUSTUP_ARCH}" -OutFile rustup-init.exe
.\rustup-init.exe -y --default-host=${env:RUSTUP_ARCH}-pc-windows-msvc --profile=minimal
del rustup-init.exe
shell: powershell
- name: Ensure stable toolchain is up to date
run: rustup update stable
shell: bash
- name: Install the target
run: |
rustup target install ${{ matrix.target }}
Expand All @@ -166,7 +165,9 @@ jobs:
# os-specific code leads to lints escaping if we only run this in one target
run: |
cargo check --all --all-targets --features test
git ls-files -- '*.rs' | xargs touch
git -c core.quotePath=false ls-files -- '*.rs' | ForEach-Object {
(Get-Item -LiteralPath $_).LastWriteTime = Get-Date
}
- name: Run cargo clippy
if: matrix.mode != 'release' && matrix.mingwdir == ''
env:
Expand All @@ -191,7 +192,6 @@ jobs:
if: github.event_name == 'push' && matrix.mode == 'release' && (github.ref == 'refs/heads/stable' || github.ref == 'refs/heads/main')
run: |
.\ci\prepare-deploy.ps1
shell: powershell
- name: Deploy build to dev-static dist tree for release team
if: github.event_name == 'push' && github.ref == 'refs/heads/stable' && matrix.mode == 'release'
run: |
Expand Down Expand Up @@ -223,6 +223,10 @@ jobs:
build-windows-main: # job-name skip-pr skip-stable
runs-on: ${{ matrix.os || 'windows-latest' }}
if: ${{ github.event_name == 'push' && (github.ref_name == 'main' || startsWith(github.ref_name, 'release/')) }} # skip-pr skip-stable
defaults:
run:
# Keep Git's Perl out of the OpenSSL build and stop on native command failures.
shell: pwsh -Command $ErrorActionPreference='stop'; $PSNativeCommandUseErrorActionPreference=$true; & '{0}'
env:
RUSTFLAGS: -Ctarget-feature=+crt-static
RUST_MIN_STACK: 16777216
Expand Down Expand Up @@ -273,7 +277,6 @@ jobs:
run: |
New-Item "${env:USERPROFILE}\.cargo\registry" -ItemType Directory -Force
New-Item "${env:USERPROFILE}\.cargo\git" -ItemType Directory -Force
shell: powershell
- name: Install NASM
# Building `aws-lc-rs` for Windows MSVC depends on `NASM`.
# See: https://aws.github.io/aws-lc-rs/requirements/windows.html
Expand All @@ -285,7 +288,6 @@ jobs:
with:
architecture: ${{ matrix.arch }}
- name: Install llvm-mingw
shell: powershell
if: matrix.llvm_mingw_version != ''
run: |
$version = "${{ matrix.llvm_mingw_version }}"
Expand All @@ -306,7 +308,6 @@ jobs:
"CC_${targetEnvUpper}=${{ matrix.gcc }}" | Out-File -Append -FilePath $env:GITHUB_ENV -Encoding utf8
"CARGO_TARGET_${targetEnvUpper}_LINKER=${{ matrix.gcc }}" | Out-File -Append -FilePath $env:GITHUB_ENV -Encoding utf8
- name: Verify mingw gcc installation
shell: powershell
if: matrix.gcc != ''
run: |
Get-Command ${{ matrix.gcc }}
Expand Down Expand Up @@ -347,10 +348,8 @@ jobs:
Invoke-WebRequest "https://win.rustup.rs/${env:RUSTUP_ARCH}" -OutFile rustup-init.exe
.\rustup-init.exe -y --default-host=${env:RUSTUP_ARCH}-pc-windows-msvc --profile=minimal
del rustup-init.exe
shell: powershell
- name: Ensure stable toolchain is up to date
run: rustup update stable
shell: bash
- name: Install the target
run: |
rustup target install ${{ matrix.target }}
Expand All @@ -366,7 +365,9 @@ jobs:
# os-specific code leads to lints escaping if we only run this in one target
run: |
cargo check --all --all-targets --features test
git ls-files -- '*.rs' | xargs touch
git -c core.quotePath=false ls-files -- '*.rs' | ForEach-Object {
(Get-Item -LiteralPath $_).LastWriteTime = Get-Date
}
- name: Run cargo clippy
if: matrix.mode != 'release' && matrix.mingwdir == ''
env:
Expand All @@ -391,7 +392,6 @@ jobs:
if: github.event_name == 'push' && matrix.mode == 'release' && (github.ref == 'refs/heads/stable' || github.ref == 'refs/heads/main')
run: |
.\ci\prepare-deploy.ps1
shell: powershell
- name: Deploy build to dev-static dist tree for release team
if: github.event_name == 'push' && github.ref == 'refs/heads/stable' && matrix.mode == 'release'
run: |
Expand Down Expand Up @@ -423,6 +423,10 @@ jobs:
build-windows-stable: # job-name skip-main skip-pr
runs-on: ${{ matrix.os || 'windows-latest' }}
if: ${{ github.event_name == 'push' && github.ref_name == 'stable' || contains(fromJSON('["schedule", "workflow_dispatch"]'), github.event_name) }} # skip-pr skip-main
defaults:
run:
# Keep Git's Perl out of the OpenSSL build and stop on native command failures.
shell: pwsh -Command $ErrorActionPreference='stop'; $PSNativeCommandUseErrorActionPreference=$true; & '{0}'
env:
RUSTFLAGS: -Ctarget-feature=+crt-static
RUST_MIN_STACK: 16777216
Expand Down Expand Up @@ -479,7 +483,6 @@ jobs:
run: |
New-Item "${env:USERPROFILE}\.cargo\registry" -ItemType Directory -Force
New-Item "${env:USERPROFILE}\.cargo\git" -ItemType Directory -Force
shell: powershell
- name: Install NASM
# Building `aws-lc-rs` for Windows MSVC depends on `NASM`.
# See: https://aws.github.io/aws-lc-rs/requirements/windows.html
Expand All @@ -491,7 +494,6 @@ jobs:
with:
architecture: ${{ matrix.arch }}
- name: Install llvm-mingw
shell: powershell
if: matrix.llvm_mingw_version != ''
run: |
$version = "${{ matrix.llvm_mingw_version }}"
Expand All @@ -512,7 +514,6 @@ jobs:
"CC_${targetEnvUpper}=${{ matrix.gcc }}" | Out-File -Append -FilePath $env:GITHUB_ENV -Encoding utf8
"CARGO_TARGET_${targetEnvUpper}_LINKER=${{ matrix.gcc }}" | Out-File -Append -FilePath $env:GITHUB_ENV -Encoding utf8
- name: Verify mingw gcc installation
shell: powershell
if: matrix.gcc != ''
run: |
Get-Command ${{ matrix.gcc }}
Expand Down Expand Up @@ -553,10 +554,8 @@ jobs:
Invoke-WebRequest "https://win.rustup.rs/${env:RUSTUP_ARCH}" -OutFile rustup-init.exe
.\rustup-init.exe -y --default-host=${env:RUSTUP_ARCH}-pc-windows-msvc --profile=minimal
del rustup-init.exe
shell: powershell
- name: Ensure stable toolchain is up to date
run: rustup update stable
shell: bash
- name: Install the target
run: |
rustup target install ${{ matrix.target }}
Expand All @@ -572,7 +571,9 @@ jobs:
# os-specific code leads to lints escaping if we only run this in one target
run: |
cargo check --all --all-targets --features test
git ls-files -- '*.rs' | xargs touch
git -c core.quotePath=false ls-files -- '*.rs' | ForEach-Object {
(Get-Item -LiteralPath $_).LastWriteTime = Get-Date
}
- name: Run cargo clippy
if: matrix.mode != 'release' && matrix.mingwdir == ''
env:
Expand All @@ -597,7 +598,6 @@ jobs:
if: github.event_name == 'push' && matrix.mode == 'release' && (github.ref == 'refs/heads/stable' || github.ref == 'refs/heads/main')
run: |
.\ci\prepare-deploy.ps1
shell: powershell
- name: Deploy build to dev-static dist tree for release team
if: github.event_name == 'push' && github.ref == 'refs/heads/stable' && matrix.mode == 'release'
run: |
Expand Down
14 changes: 7 additions & 7 deletions ci/actions-templates/windows-builds-template.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,10 @@ jobs: # skip-main skip-pr skip-stable
if: ${{ contains(fromJSON('["pull_request", "merge_group"]'), github.event_name) }} # skip-main skip-stable
if: ${{ github.event_name == 'push' && (github.ref_name == 'main' || startsWith(github.ref_name, 'release/')) }} # skip-pr skip-stable
if: ${{ github.event_name == 'push' && github.ref_name == 'stable' || contains(fromJSON('["schedule", "workflow_dispatch"]'), github.event_name) }} # skip-pr skip-main
defaults:
run:
# Keep Git's Perl out of the OpenSSL build and stop on native command failures.
shell: pwsh -Command $ErrorActionPreference='stop'; $PSNativeCommandUseErrorActionPreference=$true; & '{0}'
env:
RUSTFLAGS: -Ctarget-feature=+crt-static
RUST_MIN_STACK: 16777216
Expand Down Expand Up @@ -64,7 +68,6 @@ jobs: # skip-main skip-pr skip-stable
run: |
New-Item "${env:USERPROFILE}\.cargo\registry" -ItemType Directory -Force
New-Item "${env:USERPROFILE}\.cargo\git" -ItemType Directory -Force
shell: powershell
- name: Install NASM
# Building `aws-lc-rs` for Windows MSVC depends on `NASM`.
# See: https://aws.github.io/aws-lc-rs/requirements/windows.html
Expand All @@ -76,7 +79,6 @@ jobs: # skip-main skip-pr skip-stable
with:
architecture: ${{ matrix.arch }}
- name: Install llvm-mingw
shell: powershell
if: matrix.llvm_mingw_version != ''
run: |
$version = "${{ matrix.llvm_mingw_version }}"
Expand All @@ -97,7 +99,6 @@ jobs: # skip-main skip-pr skip-stable
"CC_${targetEnvUpper}=${{ matrix.gcc }}" | Out-File -Append -FilePath $env:GITHUB_ENV -Encoding utf8
"CARGO_TARGET_${targetEnvUpper}_LINKER=${{ matrix.gcc }}" | Out-File -Append -FilePath $env:GITHUB_ENV -Encoding utf8
- name: Verify mingw gcc installation
shell: powershell
if: matrix.gcc != ''
run: |
Get-Command ${{ matrix.gcc }}
Expand Down Expand Up @@ -138,10 +139,8 @@ jobs: # skip-main skip-pr skip-stable
Invoke-WebRequest "https://win.rustup.rs/${env:RUSTUP_ARCH}" -OutFile rustup-init.exe
.\rustup-init.exe -y --default-host=${env:RUSTUP_ARCH}-pc-windows-msvc --profile=minimal
del rustup-init.exe
shell: powershell
- name: Ensure stable toolchain is up to date
run: rustup update stable
shell: bash
- name: Install the target
run: |
rustup target install ${{ matrix.target }}
Expand All @@ -157,7 +156,9 @@ jobs: # skip-main skip-pr skip-stable
# os-specific code leads to lints escaping if we only run this in one target
run: |
cargo check --all --all-targets --features test
git ls-files -- '*.rs' | xargs touch
git -c core.quotePath=false ls-files -- '*.rs' | ForEach-Object {
Comment thread
Cloud0310 marked this conversation as resolved.
(Get-Item -LiteralPath $_).LastWriteTime = Get-Date
}
- name: Run cargo clippy
if: matrix.mode != 'release' && matrix.mingwdir == ''
env:
Expand All @@ -182,7 +183,6 @@ jobs: # skip-main skip-pr skip-stable
if: github.event_name == 'push' && matrix.mode == 'release' && (github.ref == 'refs/heads/stable' || github.ref == 'refs/heads/main')
run: |
.\ci\prepare-deploy.ps1
shell: powershell
- name: Deploy build to dev-static dist tree for release team
if: github.event_name == 'push' && github.ref == 'refs/heads/stable' && matrix.mode == 'release'
run: |
Expand Down
Loading