Improve logs when recovering from an interrupted installation#4725
Draft
FranciscoTGouveia wants to merge 1 commit intorust-lang:mainfrom
Draft
Improve logs when recovering from an interrupted installation#4725FranciscoTGouveia wants to merge 1 commit intorust-lang:mainfrom
FranciscoTGouveia wants to merge 1 commit intorust-lang:mainfrom
Conversation
FranciscoTGouveia
changed the title
rami3l
reviewed
Feb 20, 2026
| for component in update.components_to_uninstall { | ||
| // If there are no components installed, we don't need to keep | ||
| // checking, we can simply exit the loop earlier. | ||
| if self.installation.list()?.is_empty() { |
Member
There was a problem hiding this comment.
I think in principle this fix is correct, thanks!
However, isn't .list() doing a FS read every time in this loop? I'd imagine the result of .installation.list() to be perfectly predictable (don't care about ToC/ToU for now), so may I ask what do we have in .components_to_uninstall and .installation.list() here?
In other words, could these be two sets of elements of the same format, so that we can make a difference?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #4724.
Currently, when a toolchain installation is retried after being interrupted, an excessive number of warnings are emitted.
This patch detects that situation, skips the redundant warnings, and prints a single, more informative message instead.
I would appreciate any feedback on the wording of the new message.
For reference, I leave below the before and after:
Before:
After: