Avoid initializing nested Git repository#2285
Open
senekor wants to merge 1 commit intorust-lang:mainfrom
Open
Conversation
Contributor
|
I would prefer checking the current directory and every other parent directory for the existence of a |
Contributor
Author
|
That seems good, yes. Jujutsu colocates repos by default these days, so I think looking for |
Contributor
|
Sometimes, I deactivate the colocation. But yeah, if you do so, then you know what you are doing. Can you please implement that instead of this PR? :) |
senekor
force-pushed
the
senekor/kvtomxvosvvx
branch
from
7187ad6 to
3f49c95
Compare
Contributor
Author
|
Done. I checked for |
Previously a Git repository was initialized if a Cargo workspace was detected. However, it's also possible for users to initialize rustlings in an existing Git repository that doesn't contain a Cargo workspace. In that case, it's still undesirable to initialize a nested Git repository for rustlings. We therefore search all ancestors of the current working directory for `.git` or `.jj` directories to determine if rustlings is being initialized in an existing Git repository.
senekor
force-pushed
the
senekor/kvtomxvosvvx
branch
from
3f49c95 to
17ff889
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously a Git repository was initialized if a Cargo workspace was detected. However, it's also possible for users to initialize rustlings in an existing Git repository that doesn't contain a Cargo workspace. In that case, it's still undesirable to initialize a nested Git repository for rustlings. We therefore call Git directly to determine if rustlings is being initialized in an existing Git repository.