Fix brace placement for multiline control flow - #7005
Open
subotac wants to merge 1 commit into
Open
Conversation
rustbot
added
the
S-waiting-on-review
ytmimi
added
the
S-on-hold
Contributor
|
Marking this one as on-hold since I'd like to get a second opinion from someone on the style-team about the original issue. |
ytmimi
removed
the
S-on-hold
Contributor
|
Got confirmation that this is an issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #7003.
The multiline-condition brace check included the surrounding assignment offset when comparing indentation. This incorrectly kept the opening brace on the condition's final line.
For Style Edition 2027, compare against the leading indentation of the control-flow expression, matching the Rust Style Guide. Style Edition 2024 behavior remains unchanged.
Tests
Added source/target regression fixtures for Style Editions 2024 and 2027.