Add feedable query modifier - #2942
Open
blyxyas wants to merge 1 commit into
Open
Conversation
Collaborator
|
Thanks for the PR. If you have write access, feel free to merge this PR if it does not need reviews. You can request a review using |
rustbot
added
the
S-waiting-on-review
Member
Author
|
As I'm not sure if this should need a review, just to be safe ❤️ r? rustc-dev-guide |
Member
Author
|
r? @tshepang seems that you're more active in this repo :) |
tshepang
reviewed
Aug 11, 2026
|
|
||
| [query-model]: ./query-evaluation-model-in-detail.html | ||
| [try_mark_green]: https://doc.rust-lang.org/nightly/nightly-rustc/src/rustc_middle/dep_graph/graph.rs.html | ||
| [`crate_for_resolver`]: https://doc.rust-lang.org/nightly/nightly-rustc/rustc_middle/ty/struct.TyCtxtFeed.html#method.crate_for_resolver |
Member
There was a problem hiding this comment.
looks like this is not used anywhere
tshepang
reviewed
Aug 11, 2026
| be cached to disk for "local" keys, because values for external crates should | ||
| be loadable from crate metadata instead. | ||
|
|
||
| - `feedable` - The query is not actually a function, but it's own arena type. This |
Member
There was a problem hiding this comment.
Suggested change
| - `feedable` - The query is not actually a function, but it's own arena type. This | |
| - `feedable` - The query is not actually a function, but its own arena type. This |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've been scratching my head for the past half hour at this. Thankfully I've finally figured it out :)