Skip to content

Download, rather than sccache-cache, LLVM in CI#99967

Merged
bors merged 4 commits intorust-lang:masterfrom
Mark-Simulacrum:download-llvm-ci
Aug 21, 2022
Merged

Download, rather than sccache-cache, LLVM in CI#99967
bors merged 4 commits intorust-lang:masterfrom
Mark-Simulacrum:download-llvm-ci

Conversation

@Mark-Simulacrum
Copy link
Copy Markdown
Member

@Mark-Simulacrum Mark-Simulacrum commented Jul 30, 2022

My hope/expectation is that we can do better than sccache in CI for cached builds -- currently it looks like on macOS those still take upwards of 10-11 minutes, which is a significant amount of time that we could potentially cut.

This enables this mode for all non-dist builders; this should avoid any problems with the artifacts we distribute, while also providing for faster test builders (since they'll make use of PGO'd LLVM on the platforms we do that on, which is hopefully a nice win). It slightly increases the chance of test builders starting to fail only after a PR is merged (if PGO changes runtime behavior), but that should hopefully never happen, so I think this is worthwhile.

Measurements on the PR for apple-1 don't show any noticeable improvement in CI times, but those can be pretty noisy -- I'm inclined to land this since it should pretty much always be better and we can reconsider if that ever turns out not to be the case.

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants