Replace #[default_method_body_is_const] with #[const_trait]#96964
Merged
bors merged 5 commits intorust-lang:masterfrom May 30, 2022
Merged
Replace #[default_method_body_is_const] with #[const_trait]#96964bors merged 5 commits intorust-lang:masterfrom
#[default_method_body_is_const] with #[const_trait]#96964bors merged 5 commits intorust-lang:masterfrom
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pulled out of #96077
related issues: #67792 and #92158
cc @fee1-dead
This is groundwork to only allowing
impl const Traitfor traits that are marked with#[const_trait]. This is necessary to prevent adding a new default method from becoming a breaking change (as it could be a non-const fn).