rustc_codegen_llvm: Remove (almost) unused span parameter from many functions in metadata.rs#92729
Merged
bors merged 1 commit intorust-lang:masterfrom Jan 18, 2022
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Many functions and intermediate data structures in
rustc_codegen_llvm/src/debuginfo/metadata.rstake a span parameter that is only used for providing a span to aspan_bug!()invocation, in case the debuginfo typemap gets corrupted. However, this span does not really convey useful information as it just points to the first point a type is used -- and half of the time is initialized toDUMMY_SP.This PR removes this span parameter from the module.
It also removes the following unused parameters from
composite_type_metadata()together with an outdated comment: