Skip to content

Enable MIR inlining#91743

Merged
bors merged 12 commits intorust-lang:masterfrom
cjgillot:enable_mir_inlining_inline_all
Jul 2, 2022
Merged

Enable MIR inlining#91743
bors merged 12 commits intorust-lang:masterfrom
cjgillot:enable_mir_inlining_inline_all

Conversation

@cjgillot
Copy link
Contributor

@cjgillot cjgillot commented Dec 10, 2021

Continuation of #82280 by @wesleywiser.

#82280 has shown nice compile time wins could be obtained by enabling MIR inlining.
Most of the issues in #81567 are now fixed,
except the interaction with polymorphization which is worked around specifically.

I believe we can proceed with enabling MIR inlining in the near future
(preferably just after beta branching, in case we discover new issues).

Steps before merging:

  • figure out the interaction with polymorphization;
  • figure out how miri should deal with extern types;
  • silence the extra arithmetic overflow warnings;
  • remove the codegen fulfilment ICE;
  • remove the type normalization ICEs while compiling nalgebra;
  • tweak the inlining threshold.

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-mir-opt Area: MIR optimizations A-mir-opt-inlining Area: MIR inlining merged-by-bors This PR was explicitly merged by bors. perf-regression Performance regression. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.