Skip to content

Feat: added caching schema for debuginfo type names#88898

Closed
Sl1mb0 wants to merge 11 commits intorust-lang:masterfrom
Sl1mb0:cache-debuginfo-type-names
Closed

Feat: added caching schema for debuginfo type names#88898
Sl1mb0 wants to merge 11 commits intorust-lang:masterfrom
Sl1mb0:cache-debuginfo-type-names

Conversation

@Sl1mb0
Copy link
Contributor

@Sl1mb0 Sl1mb0 commented Sep 12, 2021

This is a WIP addressing #86431. This PR aims to accomplish two things:

  • Implements a caching schema to avoid redundant calls to compute_debuginfo_type_name().
  • Add profiling support for determining the amount of redundant computations that would be performed, if the caching schema were not implemented.
    • As for how: I plan to just use counters to track how many times we call compute_debuginfo_type_name() and how many times we return a name for the cache. @rylev also suggested that determining how many individual memory allocations occur each time redundant work is performed, but I am unsure of how to go about this.

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.

Projects

None yet

Development

Successfully merging this pull request may close these issues.