Merged
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduce
OwnedFdandBorrowedFd, and theAsFdtrait, andimplementations of
AsFd,From<OwnedFd>andFrom<T> for OwnedFdfor relevant types, along with Windows counterparts for handles and
sockets.
Tracking issue: #87074
RFC: https://github.com/rust-lang/rfcs/blob/master/text/3128-io-safety.md
Highlights:
RawHandlestruct the Windows impl, which had the same name as theRawHandletype alias, and its functionality is now folded intoHandle.Managing five levels of wrapping (File wraps sys::fs::File wraps sys::fs::FileDesc wraps OwnedFd wraps RawFd, etc.) made for a fair amount of churn and verbose as/into/from sequences in some places. I've managed to simplify some of them, but I'm open to ideas here.
r? @joshtriplett