Remove #[cfg] attributes during cfg-expansion#84110
Closed
Aaron1011 wants to merge 1 commit intorust-lang:masterfrom
Closed
Remove #[cfg] attributes during cfg-expansion#84110Aaron1011 wants to merge 1 commit intorust-lang:masterfrom
#[cfg] attributes during cfg-expansion#84110Aaron1011 wants to merge 1 commit intorust-lang:masterfrom
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
17 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, we don't remove
#[cfg]attributes from a target when thepredicates pass. This PR removes all 'passing'
#[cfg]attributesduring cfg-expansion, which causes derive proc-macros to never see any
#[cfg]attributes in the input token stream.With #82608 merged, we can now do
this without losing spans.