Fix impl being removed excessively#82496
Closed
GuillaumeGomez wants to merge 1 commit intorust-lang:masterfrom
Closed
Fix impl being removed excessively#82496GuillaumeGomez wants to merge 1 commit intorust-lang:masterfrom
GuillaumeGomez wants to merge 1 commit intorust-lang:masterfrom
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
12 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #82465.
To prevent some impls to get removed, the type has to be "registered". This is because of the change from 8eaf68f , before that commit, the impls were filtered before we added the multiple
Deref"go down".cc @jryans
r? @jyn514