Skip to content

rustdoc DocFragment rework#80261

Merged
bors merged 6 commits intorust-lang:masterfrom
GuillaumeGomez:attr-rework
Jan 3, 2021
Merged

rustdoc DocFragment rework#80261
bors merged 6 commits intorust-lang:masterfrom
GuillaumeGomez:attr-rework

Conversation

@GuillaumeGomez
Copy link
Copy Markdown
Member

@GuillaumeGomez GuillaumeGomez commented Dec 21, 2020

Kind of a follow-up of #80119.

A few things are happening in this PR. I'm not sure about the impact on perf though so I'm very interested about that too (if the perf is worse, then we can just close this PR).

The idea here is mostly about reducing the memory usage by relying even more on Symbol instead of String. The only issue is that DocFragment has 3 modifications performed on it:

  1. Unindenting
  2. Collapsing similar comments into one
  3. "Beautifying" (weird JS-like comments handling).

To do so, I saved the information about unindent and the "collapse" is now on-demand (which is why I'm not sure the perf will be better, it has to be run multiple times...).

r? @jyn514

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants