Use is_write_vectored to optimize the write_vectored implementation for BufWriter#78768
Merged
bors merged 4 commits intorust-lang:masterfrom Dec 9, 2020
Merged
Use is_write_vectored to optimize the write_vectored implementation for BufWriter#78768bors merged 4 commits intorust-lang:masterfrom
bors merged 4 commits intorust-lang:masterfrom
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In case when the underlying writer does not have an efficient implementation
write_vectored, the present implementation ofwrite_vectoredforBufWritermay still forward vectored writes directly to the writer depending on the total length of the data. This misses the advantage of buffering, as the actually written slice may be small.Provide an alternative code path for the non-vectored case, where the slices passed to
BufWriterare coalesced in the buffer before being flushed to the underlying writer with plainwritecalls. The buffer is only bypassed if an individual slice's length is at least as large as the buffer.Remove a FIXME comment referring to #72919 as the issue has been closed with an explanation provided.