Fix primitive retrieval in search index generation#74879
Closed
GuillaumeGomez wants to merge 4 commits intorust-lang:masterfrom
Closed
Fix primitive retrieval in search index generation#74879GuillaumeGomez wants to merge 4 commits intorust-lang:masterfrom
GuillaumeGomez wants to merge 4 commits intorust-lang:masterfrom
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #60485. Fixes #74780.
Before merging, I have a few questions remaining:
Should we remove the
primitive_locationsfield from theCachetype? If so, we'll have to replace in the few places where we use this field (not really a problem). However, this field includes the primitive types of the current crates, whereas my new implementation only includes the ones coming from external crates. I'm not sure if it'll be an issue for libcore or not (maybe not since they can be retrieved directly inside the crate, no?).EDIT: I removed the
primitive_locationsfield from theCachetype, so now we're only referring/using the new "primitives cache" added by this PR.cc @rust-lang/rustdoc
r? @Manishearth