Conversation
|
@bors try @rust-timer queue |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
[perf] do not parse non-crate lint attributes during pre-expansion lint passes
|
cc @JonathanBrouwer I do not expect this to be merged, but something like this is a solution to our lint attribute parsing woes :) |
|
The job Click to see the possible cause of the failure (guessed by this bot) |
This comment has been minimized.
This comment has been minimized.
|
Finished benchmarking commit (95b2a87): comparison URL. Overall result: no relevant changes - no action neededBenchmarking means the PR may be perf-sensitive. Consider adding rollup=never if this change is not fit for rolling up. @rustbot label: -S-waiting-on-perf -perf-regression Instruction countThis perf run didn't have relevant results for this metric. Max RSS (memory usage)Results (primary -2.5%)A less reliable metric. May be of interest, but not used to determine the overall result above.
CyclesResults (secondary 1.6%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Binary sizeThis perf run didn't have relevant results for this metric. Bootstrap: 492.227s -> 490.376s (-0.38%) |
This has the effect of skipping a lot of attribute parsing.
It also makes code like this compile:
(it would also require that all pre expansion lints must be crate-level only, so this is going to lead to some clippy fallout)