codegen Propagate reported errors from ABI checks - #163713
Open
Dnreikronos wants to merge 2 commits into
Open
Dnreikronos wants to merge 2 commits into
Dnreikronos wants to merge 2 commits into
Conversation
Collaborator
|
r? @Enselic rustbot has assigned @Enselic. Use Why was this reviewer chosen?The reviewer was selected based on:
|
Collaborator
|
The job Click to see the possible cause of the failure (guessed by this bot) |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #162814
The oversized array already gets an E0080 error. Normalization keeps the failed constant as an error marker in the buffer's type, though, and computing the constructor's return layout gives
ReferencesError. The shared ABI handler then hitsspan_bug!, so we get an ICE on top of the useful error.Handle
ReferencesErrorby returning its existingErrorGuaranteed. The ABI checks can then return through their usual error path, and mono collection stops before codegen. I think the shared handler is the right place for this because it already decides how to report ABI failures. Const-eval handles this variant by keeping the reported error too.I reduced the async example to a small buffer constructor with no external crates. The test uses
build-failso it reaches the ABI checks, with default and optimized revisions to cover both paths.Rebuilt the compiler and ran both new revisions plus the existing oversized-layout test. All three passed. Compiler checks and formatting passed too. Clippy completed with existing warnings allowed.