Conversation
Collaborator
Collaborator
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A while back, I made three PRs removing def_id from AliasConst/AliasTerm/AliasTy:
I did AliasConst first, and due to my inexperience with this refactor, I had this
opt_def_idkludge. I didn't do the same thing in the AliasTy or AliasTerm PRs. It ought to be removed and replaced with explicit matches.This PR conflicts with #162760 - please merge that one first! the code in this PR is a bit kludgey until that PR is merged.
related tracking-ish issues:
Alias[Ty|Const|Term]KindintoAlias[Ty|Const|Term], generalize to not require just aDefId#152245AliasTermrefactor #156181ConstKind::UnevaluatedandTyKind::Aliasand allow non defid/subst pairs project-const-generics#98r? @BoxyUwU