Skip to content

libtest: do not early exit from test runners - #162796

Open
RalfJung wants to merge 2 commits into
rust-lang:mainfrom
RalfJung:libtest-no-early-exit
Open

RalfJung wants to merge 2 commits into
rust-lang:mainfrom
RalfJung:libtest-no-early-exit

Conversation

@RalfJung

@RalfJung RalfJung commented Sep 15, 2026

Copy link
Copy Markdown
Member

Suggested by @Mark-Simulacrum in #161868. I finally figured out why my earlier attempts did not work.

@rustbot rustbot added A-rustc-dev-guide Area: rustc-dev-guide S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-clippy Relevant to the Clippy team. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Sep 15, 2026
@RalfJung

Copy link
Copy Markdown
Member Author

@bors try job=dist-x86_64-msvc

@rust-bors

This comment has been minimized.

rust-bors Bot pushed a commit that referenced this pull request Sep 15, 2026
libtest: do not early exit from test runners


try-job: dist-x86_64-msvc
@rust-log-analyzer

This comment has been minimized.

@rust-bors

rust-bors Bot commented Sep 15, 2026

Copy link
Copy Markdown
Contributor

💔 Test for 40346c4 failed: CI. Failed job:

@RalfJung
RalfJung force-pushed the libtest-no-early-exit branch from 5dd5372 to 7c7e382 Compare September 15, 2026 08:49
It does not look like these items are actually used by rustc.
@RalfJung
RalfJung force-pushed the libtest-no-early-exit branch from 7c7e382 to 5fd598e Compare September 15, 2026 10:43
@RalfJung
RalfJung marked this pull request as ready for review September 15, 2026 10:43
@rustbot

rustbot commented Sep 15, 2026

Copy link
Copy Markdown
Collaborator

clippy is developed in its own repository. If possible, consider making this change to rust-lang/rust-clippy instead.

cc @rust-lang/clippy

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 15, 2026
@rustbot rustbot removed the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Sep 15, 2026
@rustbot

rustbot commented Sep 15, 2026

Copy link
Copy Markdown
Collaborator

r? @oli-obk

rustbot has assigned @oli-obk.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: compiler
  • compiler expanded to 76 candidates
  • Random selection from 19 candidates

@RalfJung

Copy link
Copy Markdown
Member Author

@bors try job=dist-x86_64-msvc,testmsvc

@rust-bors

rust-bors Bot commented Sep 15, 2026

Copy link
Copy Markdown
Contributor

⌛ Trying commit 5fd598e with merge 06e803b

To cancel the try build, run the command @bors try cancel.

Workflow: https://github.com/rust-lang/rust/actions/runs/34959651710

rust-bors Bot pushed a commit that referenced this pull request Sep 15, 2026
libtest: do not early exit from test runners


try-job: dist-x86_64-msvc
try-job: test*msvc*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-rustc-dev-guide Area: rustc-dev-guide S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-clippy Relevant to the Clippy team. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants