RISC-V: prepend --no-relax-gp to linker arguments - #162772
Open
TechnoPorg wants to merge 1 commit into
Open
TechnoPorg wants to merge 1 commit into
TechnoPorg wants to merge 1 commit into
Conversation
Collaborator
|
These commits modify compiler targets. |
Collaborator
|
Thanks for the pull request, and welcome! The Rust Project has assigned @mati865 (or someone else) to review your changes, you should hear from them (or someone else) within the next two weeks. Please see the contribution instructions and our LLM policy for more information. Why was this reviewer chosen?The reviewer was selected based on:
|
Author
|
@rustbot label O-riscv |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As suggested in #t-compiler/linker > RISC-V global pointer relaxations, this prepends
--no-relax-gpto the link args on RISC-V to be sure we're not performing global pointer relaxations on a target that may not support them. This is with the goal of eventually stabilizing therelaxtarget feature, as afaict behaviour aroundgpis the remaining blocker.I also have a branch where
relaxis enabled by default on these targets (#t-compiler/risc-v > Should `-C target-feature=+relax` become the default?), but the benefits are less clear-cut than I thought they would be, so this is a safer starting point.In the future, this could be switched to
--relax-gpon targets known to support global pointer relaxations. If people want to opt in (say, for a bare metal target where they've independently set up gp), they can just add-Clink-arg={-Wl,}--relax-gp.r? wg-linker