Skip to content

[beta] make semicolon_in_expressions_from_non_local_macros not report-in-deps - #162765

Open
RalfJung wants to merge 1 commit into
rust-lang:betafrom
RalfJung:semicolon_in_expressions_from_non_local_macros
Open

RalfJung wants to merge 1 commit into
rust-lang:betafrom
RalfJung:semicolon_in_expressions_from_non_local_macros

Conversation

@RalfJung

Copy link
Copy Markdown
Member

See discussion on Zulip:

  • The lint is showing up a lot more than people seem to have expected.
  • "Warn" + "report-in-deps" is not a combination we usually use.
  • This is going to be released soon, let's buy ourselves some time.

Cc @joshtriplett @petrochenkov

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Sep 14, 2026
@rustbot

rustbot commented Sep 14, 2026

Copy link
Copy Markdown
Collaborator

r? @davidtwco

rustbot has assigned @davidtwco.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: compiler
  • compiler expanded to 76 candidates
  • Random selection from 18 candidates

@RalfJung

Copy link
Copy Markdown
Member Author

@Kobzol shouldn't the bot print a warning because this PR is not against the main branch...?

@cyrgani

cyrgani commented Sep 14, 2026

Copy link
Copy Markdown
Contributor

the warning is not shown when the PR title contains [beta: https://forge.rust-lang.org/triagebot/pr-assignment.html#exceptions-to-default-branch-warning

@RalfJung

Copy link
Copy Markdown
Member Author

Ah :)

@joshtriplett

Copy link
Copy Markdown
Member

r=me . Not because I necessarily think we should revert this, but because it's close to release, this isn't urgent, and reverting it gives us time to evaluate. So, 👍 for deferring it so we don't feel rushed.

@RalfJung

Copy link
Copy Markdown
Member Author

Cc @BoxyUwU (are you managing the upcoming release?)

@theemathas

Copy link
Copy Markdown
Contributor

@Mark-Simulacrum is handling the 1.99.0 release.

@Mark-Simulacrum

Copy link
Copy Markdown
Member

@bors r=joshtriplett rollup=never

@rust-bors

rust-bors Bot commented Sep 15, 2026

Copy link
Copy Markdown
Contributor

📌 Commit 6e247f2 has been approved by joshtriplett

It is now in the queue for this repository.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants