Skip to content

m68k-unknown-none-elf: Remove code model and change CPU to base MC68000 - #161152

Open
techmetx11 wants to merge 2 commits into
rust-lang:mainfrom
techmetx11:m68k-target-specs
Open

m68k-unknown-none-elf: Remove code model and change CPU to base MC68000#161152
techmetx11 wants to merge 2 commits into
rust-lang:mainfrom
techmetx11:m68k-target-specs

Conversation

@techmetx11

@techmetx11 techmetx11 commented Aug 16, 2026

Copy link
Copy Markdown

This PR removes the code model because it causes issues when compiling with rustc_codegen_gcc (the code model option doesn't exist in GCC for m68k), and changes the CPU from M68010 to M68000, since it seems like an arbitrary CPU choice over the first CPU in the Motorola 68000 series that the compiler can compile for

r? @knickish

@rustbot

rustbot commented Aug 16, 2026

Copy link
Copy Markdown
Collaborator

These commits modify compiler targets.
(See the Target Tier Policy.)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Aug 16, 2026
@rustbot

rustbot commented Aug 16, 2026

Copy link
Copy Markdown
Collaborator

Failed to set assignee to knickish: invalid assignee

Note: Only org members with at least the repository "read" role, users with write permissions, or people who have commented on the PR may be assigned.

@rustbot

rustbot commented Aug 16, 2026

Copy link
Copy Markdown
Collaborator

Thanks for the pull request, and welcome! The Rust Project is excited to review your changes, and you should hear from @knickish (or someone else) some time within the next two weeks.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

  • @rustbot author: the review is finished, PR author should check the comments and take action accordingly
  • @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

@techmetx11

techmetx11 commented Aug 16, 2026

Copy link
Copy Markdown
Author

cc @knickish (sorry)

@rust-log-analyzer

This comment has been minimized.

@jieyouxu jieyouxu self-assigned this Aug 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants