Skip to content

Stabilize core::io::{Error(Kind), IoSlice(Mut), Result} - #160951

Open
bushrat011899 wants to merge 1 commit into
rust-lang:mainfrom
bushrat011899:core_io_fundamentals_stabilization
Open

Stabilize core::io::{Error(Kind), IoSlice(Mut), Result}#160951
bushrat011899 wants to merge 1 commit into
rust-lang:mainfrom
bushrat011899:core_io_fundamentals_stabilization

Conversation

@bushrat011899

@bushrat011899 bushrat011899 commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

View all comments

Tracking Issue: #154046
Stabilization Report: #154046 (comment)
Blocked On: #160952

Description

This PR stabilizes a subset of the core_io feature, namely:

To minimize churn, I've opted to mark the above as stable under a new feature, core_io_fundamentals, leaving the unstable parts under the existing core_io feature. This PR does not propose stabilization alloc_io, or re-exports of core::io in alloc::io. That will be proposed at a later date for ease of review. I will note that I plan on submitted a stabilization PR for alloc_io in its entirety in the future as context for reviewers here though.


Notes

  • No AI tooling of any kind was used during the creation of this PR.

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Aug 11, 2026
@rustbot

rustbot commented Aug 11, 2026

Copy link
Copy Markdown
Collaborator

r? @JohnTitor

rustbot has assigned @JohnTitor.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: libs
  • libs expanded to 12 candidates
  • Random selection from JohnTitor, Mark-Simulacrum, clarfonthey, nia-e

@bushrat011899

Copy link
Copy Markdown
Contributor Author

@rustbot label +I-libs-api-nominated
@rust-lang/libs-api & @nia-e (not sure if the team ping works so hedging my bets)

@rustbot

rustbot commented Aug 11, 2026

Copy link
Copy Markdown
Collaborator

Error: relabel handler unexpectedly failed in this comment: failed to add labels to the issue

Please file an issue on GitHub at triagebot if there's a problem with this bot, or reach out on #triagebot on Zulip.

@rust-log-analyzer

This comment has been minimized.

@bushrat011899
bushrat011899 force-pushed the core_io_fundamentals_stabilization branch from 0161fa2 to fb55b6e Compare August 11, 2026 22:51
@bushrat011899

Copy link
Copy Markdown
Contributor Author

CI failure caused by a doc(hidden) trait implementation not having a stability attribute becoming an error once the core::io module was marked stable. I'm not sure why it was ok before and not ok now, but I've added the relevant unstable attribute anyway.

Comment thread library/core/src/io/cursor.rs Outdated
@rust-log-analyzer

This comment has been minimized.

@bushrat011899
bushrat011899 force-pushed the core_io_fundamentals_stabilization branch from fb55b6e to 500326c Compare August 11, 2026 23:24
@rust-log-analyzer

This comment has been minimized.

@bushrat011899
bushrat011899 force-pushed the core_io_fundamentals_stabilization branch 2 times, most recently from a9329e7 to c9ac89d Compare August 12, 2026 00:20
@rustbot rustbot added S-blocked Status: Blocked on something else such as an RFC or other implementation work. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 12, 2026
Comment thread library/core/src/io/cursor.rs
@nia-e nia-e added needs-fcp This change is insta-stable, or significant enough to need a team FCP to proceed. S-waiting-on-fcp Status: PR is in FCP and is awaiting for FCP to complete. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-blocked Status: Blocked on something else such as an RFC or other implementation work. labels Aug 12, 2026
Subset of `core_io` renamed to `core_io_fundamentals` to minimize nightly churn.
@bushrat011899
bushrat011899 force-pushed the core_io_fundamentals_stabilization branch from c9ac89d to 1f00e29 Compare August 13, 2026 04:15
@rustbot

rustbot commented Aug 13, 2026

Copy link
Copy Markdown
Collaborator

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

@JohnTitor

Copy link
Copy Markdown
Member

r? nia-e

@rustbot rustbot assigned nia-e and unassigned JohnTitor Aug 15, 2026
@nia-e nia-e added the I-libs-nominated Nominated for discussion during a libs team meeting. label Aug 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

I-libs-nominated Nominated for discussion during a libs team meeting. needs-fcp This change is insta-stable, or significant enough to need a team FCP to proceed. S-waiting-on-fcp Status: PR is in FCP and is awaiting for FCP to complete. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants