Trim GoalStalledOn::Certainty - #160886
Merged
rust-bors[bot] merged 1 commit intoAug 12, 2026
Merged
Conversation
Collaborator
|
Some changes occurred to the core trait solver cc @rust-lang/initiative-trait-system-refactor |
rustbot
added
S-waiting-on-review
lcnr
reviewed
Aug 11, 2026
lcnr
reviewed
Aug 11, 2026
nnethercote
force-pushed
the
GoalStalledOn-stalled_maybe_info
branch
from
August 11, 2026 10:40
7c7cbc5 to
9d667f0
Compare
This comment has been minimized.
This comment has been minimized.
Contributor
Author
|
This now removed a check on the ultra-hot fast path in @bors try @rust-timer queue |
Collaborator
|
Awaiting bors try build completion. @rustbot label: +S-waiting-on-perf |
This comment has been minimized.
This comment has been minimized.
rustbot
added
the
S-waiting-on-perf
rust-bors Bot
pushed a commit
that referenced
this pull request
Aug 11, 2026
… r=<try> Trim `GoalStalledOn::Certainty`
lcnr
approved these changes
Aug 11, 2026
Contributor
Collaborator
|
Queued 13539ad with parent f76a50b, future comparison URL. |
Contributor
Author
|
For some reason the perf result comment wasn't posted, so here it is: comparison URL. Basically perf-neutral, so: @bors rollup @lcnr: ready for r+? |
This comment has been minimized.
This comment has been minimized.
It's always `Certainty::Maybe`, so we can trim it down to just the `MaybeInfo` that is within `Certainty::Maybe`. And then the same change can be made to the field of `RerunStalled::WontMakeProgress`, and `goal_remains_stalled` can return a bool, and a hot `matches!` in `try_evaluate_obligations` that never failed can be removed.
nnethercote
force-pushed
the
GoalStalledOn-stalled_maybe_info
branch
from
August 11, 2026 23:25
9d667f0 to
7fe7add
Compare
Collaborator
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
Contributor
Author
|
I rebased. |
Contributor
|
@bors r+ rollup |
Contributor
rust-bors
Bot
added
S-waiting-on-bors
rust-bors Bot
pushed a commit
that referenced
this pull request
Aug 12, 2026
…uwer Rollup of 6 pull requests Successful merges: - #160966 (bootstrap: Avoid some unnecessary imports from the crate root) - #159987 (trait solver: Track canonical response universe assumptions) - #160886 (Trim `GoalStalledOn::Certainty`) - #160925 (Add `TypeId::is_signed` method) - #160926 (sve: add addl. passing test for field projection) - #160977 (Remove `MutatingUseContext::Retag`)
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's always
Certainty::Maybe, so we can trim it down to just theMaybeInfothat is withinCertainty::Maybe.r? @lcnr