ignore tests with the GCC backend if we can't find libgccjit.so for the target - #160715
Open
folkertdev wants to merge 2 commits into
Open
ignore tests with the GCC backend if we can't find libgccjit.so for the target#160715folkertdev wants to merge 2 commits into
libgccjit.so for the target#160715folkertdev wants to merge 2 commits into
Conversation
Collaborator
|
Some changes occurred in src/tools/compiletest cc @jieyouxu |
rustbot
added
A-compiletest
Collaborator
|
|
rustbot
added
S-waiting-on-review
folkertdev
changed the title
libgccjit.so for it
2 tasks
folkertdev
changed the title
libgccjit.so for itlibgccjit.so for the target
GuillaumeGomez
approved these changes
Aug 7, 2026
Member
|
Thanks for doing it! It allows to remove some |
Contributor
|
☔ The latest upstream changes (presumably #160725) made this pull request unmergeable. Please resolve the merge conflicts by rebasing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Much like we ignore tests on targets that don't support certain properties, ignore a test or revision when the target is not supported by GCC, and GCC is the default codegen backend.
With this change we can remove many
//@ ignore-backends: gcc(which I've left for later).See also the conversation at #rustc-codegen-gcc > tidy error on building test with GCC on unsupported target.
r? jieyouxu
cc @GuillaumeGomez @antoyo