Recover from tuple patterns with inline element types - #160279
Open
ArneshBanerjee wants to merge 1 commit into
Open
Recover from tuple patterns with inline element types#160279ArneshBanerjee wants to merge 1 commit into
ArneshBanerjee wants to merge 1 commit into
Conversation
Writing the type of each element inside a tuple pattern like `let (a: bool, b: u8) = ...` isn't valid, but the current error doesn't really tell you that. It just says "expected one of `)`, `,`, `@`, `if`, or `|`, found `:`" and leaves you to work it out. A let pattern can be followed by a type, so we can suggest the fix: move the types out into a tuple type after the pattern, so `(a: bool, b: u8)` becomes `(a, b): (bool, u8)`. Elements without a type just get `_`. Parsing then keeps going with the types dropped, so you only get the one error.
Collaborator
|
The parser was modified, potentially altering the grammar of (stable) Rust cc @fmease |
Collaborator
|
Thanks for the pull request, and welcome! The Rust Project is excited to review your changes, and you should hear from @folkertdev (or someone else) some time within the next two weeks. Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (
Why was this reviewer chosen?The reviewer was selected based on:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If you write the element types inside a tuple pattern:
the error you get doesn't really explain the problem:
A let pattern can have a type after it, so now we point out what to do instead:
If an element doesn't have a type written, it just gets
_, so(a: bool, b)turns into
(a, b): (bool, _).I kept this to let bindings only. That's the case where the pattern doesn't need
a type of its own, so once the types move into the suggestion the rest of the
statement parses fine and you get a single error instead of a pile of follow-up
ones. Match arms, nested patterns and function parameters are left alone.
Closes #149246