Skip to content

[PERF] rerun even if the goal has ty vars - #160254

Draft
adwinwhite wants to merge 1 commit into
rust-lang:mainfrom
adwinwhite:fix-fcw-missing
Draft

[PERF] rerun even if the goal has ty vars#160254
adwinwhite wants to merge 1 commit into
rust-lang:mainfrom
adwinwhite:fix-fcw-missing

Conversation

@adwinwhite

Copy link
Copy Markdown
Contributor

No description provided.

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. WG-trait-system-refactor The Rustc Trait System Refactor Initiative (-Znext-solver) labels Jul 31, 2026
@adwinwhite

Copy link
Copy Markdown
Contributor Author

@bors try @rust-timer queue

@rust-timer

This comment has been minimized.

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jul 31, 2026
@rust-bors

This comment has been minimized.

rust-bors Bot pushed a commit that referenced this pull request Jul 31, 2026
[PERF] rerun even if the goal has ty vars
@rust-bors

rust-bors Bot commented Jul 31, 2026

Copy link
Copy Markdown
Contributor

☀️ Try build successful (CI)
Build commit: 9c22651 (9c226517f39ac2eb73245bb4d6dcf5233fb5df63)
Base parent: 8ab9fdf (8ab9fdff5a91b9f2b5ed57fb0275452d9a0d0280)

@rust-timer

This comment has been minimized.

@rust-timer

Copy link
Copy Markdown
Collaborator

Finished benchmarking commit (9c22651): comparison URL.

Overall result: no relevant changes - no action needed

Benchmarking means the PR may be perf-sensitive. Consider adding rollup=never if this change is not fit for rolling up.

@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

This perf run didn't have relevant results for this metric.

Max RSS (memory usage)

Results (primary -1.9%, secondary 5.8%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
0.4% [0.4%, 0.4%] 1
Regressions ❌
(secondary)
5.8% [5.8%, 5.8%] 1
Improvements ✅
(primary)
-2.7% [-5.0%, -0.7%] 3
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) -1.9% [-5.0%, 0.4%] 4

Cycles

Results (primary -0.3%, secondary -0.4%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
0.6% [0.5%, 0.9%] 3
Regressions ❌
(secondary)
1.0% [0.5%, 3.4%] 7
Improvements ✅
(primary)
-1.0% [-1.7%, -0.5%] 4
Improvements ✅
(secondary)
-1.5% [-3.9%, -0.4%] 9
All ❌✅ (primary) -0.3% [-1.7%, 0.9%] 7

Binary size

Results (primary -0.1%, secondary -0.1%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
-0.1% [-0.1%, -0.0%] 38
Improvements ✅
(secondary)
-0.1% [-0.1%, -0.0%] 42
All ❌✅ (primary) -0.1% [-0.1%, -0.0%] 38

Bootstrap: 492.09s -> 490.546s (-0.31%)
Artifact size: 390.63 MiB -> 390.52 MiB (-0.03%)

@rustbot rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jul 31, 2026
@lcnr

lcnr commented Jul 31, 2026

Copy link
Copy Markdown
Contributor

alright, can you make sure this fixes the issues and add them as test, then r=me I guess 🤣

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. WG-trait-system-refactor The Rustc Trait System Refactor Initiative (-Znext-solver)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants