Skip to content

compiletest: forward disable-minification from bootstrap - #159887

Open
AayushMainali-Github wants to merge 1 commit into
rust-lang:mainfrom
AayushMainali-Github:fix-142737-forward-disable-minification
Open

compiletest: forward disable-minification from bootstrap#159887
AayushMainali-Github wants to merge 1 commit into
rust-lang:mainfrom
AayushMainali-Github:fix-142737-forward-disable-minification

Conversation

@AayushMainali-Github

@AayushMainali-Github AayushMainali-Github commented Jul 25, 2026

Copy link
Copy Markdown
Contributor

build.docs-minification = false was already honored when building docs through bootstrap's doc steps, but compiletest-driven rustdoc suites always generated minified CSS/JS.

Bootstrap now forwards --disable-minification to compiletest when docs minification is disabled, and compiletest passes -Zunstable-options --disable-minification to rustdoc for HTML/JS/JSON/UI doc generation.

Fixes #142737.

Honor build.docs-minification=false for rustdoc suites run via
compiletest by forwarding --disable-minification to rustdoc.
@rustbot

rustbot commented Jul 25, 2026

Copy link
Copy Markdown
Collaborator

Some changes occurred in src/tools/compiletest

cc @jieyouxu

compiletest directives have been modified. Please add or update docs for the
new or modified directive in src/doc/rustc-dev-guide/.

@rustbot rustbot added A-compiletest Area: The compiletest test runner A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Jul 25, 2026
@rustbot

rustbot commented Jul 25, 2026

Copy link
Copy Markdown
Collaborator

Thanks for the pull request, and welcome! The Rust Project is excited to review your changes, and you should hear from @oli-obk (or someone else) some time within the next two weeks.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

  • @rustbot author: the review is finished, PR author should check the comments and take action accordingly
  • @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue
Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: @jieyouxu, @oli-obk, @wesleywiser, bootstrap
  • @jieyouxu, @oli-obk, @wesleywiser, bootstrap expanded to 8 candidates
  • Random selection from Mark-Simulacrum, clubby789, oli-obk, wesleywiser

@oli-obk

oli-obk commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

r? rustdoc

can individual tests override this flag? or... would they want to? is that useful?

@rustbot rustbot added the T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. label Jul 28, 2026
@rustbot rustbot assigned lolbinarycat and unassigned oli-obk Jul 28, 2026
@AayushMainali-Github

Copy link
Copy Markdown
Contributor Author

No per-test override here. Tests can already add rustdoc flags via //@ doc-flags, but can't re-enable minification when bootstrap disables it. That seems fine for a global docs preference

@rust-bors

rust-bors Bot commented Jul 31, 2026

Copy link
Copy Markdown
Contributor

☔ The latest upstream changes (presumably #160284) made this pull request unmergeable. Please resolve the merge conflicts by rebasing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-compiletest Area: The compiletest test runner A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

disable-minification is not forwarded to compiletest

4 participants