Skip to content

tidy: revisions inherit global directives#157992

Open
folkertdev wants to merge 1 commit into
rust-lang:mainfrom
folkertdev:tidy-llvm-component
Open

tidy: revisions inherit global directives#157992
folkertdev wants to merge 1 commit into
rust-lang:mainfrom
folkertdev:tidy-llvm-component

Conversation

@folkertdev

Copy link
Copy Markdown
Contributor

specifically needs-llvm-components

Based on this function, directives apply to a revision also when the directive is defined "globally".

pub(crate) fn applies_to_test_revision(&self, test_revision: Option<&str>) -> bool {
self.revision.is_none() || self.revision == test_revision
}

But tidy did not take that into account.

I'm not sure how to test this.

r? jieyouxu

specifically `needs-llvm-components`
@rustbot rustbot added A-tidy Area: The tidy tool S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jun 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-tidy Area: The tidy tool S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants