Pass --no-entry to emcc when linking emscripten cdylib/dylib#157985
Open
guybedford wants to merge 1 commit into
Open
Pass --no-entry to emcc when linking emscripten cdylib/dylib#157985guybedford wants to merge 1 commit into
guybedford wants to merge 1 commit into
Conversation
A cdylib/dylib has no `main`, but rustc invokes emcc in its default executable mode, which links in emscripten's standalone-wasm entry shim and then fails with `undefined symbol: main`. Mirror the WasmLd linker: emit `--no-entry` for `DynamicDylib`/ `StaticDylib` output kinds in EmLinker::set_output_kind, conditioned on LinkOutputKind so executables keep their entry. Extend the emscripten cdylib run-make test to also link a bin crate with `main`, guarding against regressing the executable entry path.
rustbot
added
A-run-make
Collaborator
|
r? @camelid rustbot has assigned @camelid. Use Why was this reviewer chosen?The reviewer was selected based on:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A cdylib/dylib has no
main, but rustc invokes emcc in its default executable mode, which links in emscripten's standalone-wasm entry shim and then fails withundefined symbol: main.Mirror the WasmLd linker: emit
--no-entryforDynamicDylib/StaticDyliboutput kinds in EmLinker::set_output_kind, conditioned on LinkOutputKind so executables keep their entry.Extends the emscripten cdylib run-make test to also link a bin crate with
main, guarding against regressing the executable entry path.