Some minor cleanups around hir ty/pat/expr#157980
Open
oli-obk wants to merge 2 commits into
Open
Conversation
Collaborator
|
HIR ty lowering was modified cc @fmease |
rustbot
added
S-waiting-on-review
Collaborator
|
r? @folkertdev rustbot has assigned @folkertdev. Use Why was this reviewer chosen?The reviewer was selected based on:
|
fmease
reviewed
Jun 16, 2026
Member
There was a problem hiding this comment.
// `foo<N>()` in expression context, point at `foo`'s const parameter.
Could you update or remove this comment?
Member
|
@bors r+ rollup |
Contributor
rust-bors
Bot
added
S-waiting-on-bors
jhpratt
added a commit
to jhpratt/rust
that referenced
this pull request
Jun 17, 2026
Some minor cleanups around hir ty/pat/expr Just some avenues for deduplication that I noticed. Also makes sure we handle all three everywhere instead of just ty/expr like the diagnostic code previously did.
rust-bors Bot
pushed a commit
that referenced
this pull request
Jun 17, 2026
Rollup of 7 pull requests Successful merges: - #157681 (Add instrument_fn attribute) - #149219 (Allow shortening lifetime in CoerceUnsized for &mut) - #157539 (Rename `RandomSource` -> `Rng`, `DefaultRandomSource` -> `SystemRng`) - #157980 (Some minor cleanups around hir ty/pat/expr) - #157988 (Fix incremental-finalize-fail proc macro test on AIX) - #157989 (run-make: handle AIX symbol cdylib export test) - #157998 (Add big disclaimer to the description of lint `explicit_outlives_requirements`)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just some avenues for deduplication that I noticed. Also makes sure we handle all three everywhere instead of just ty/expr like the diagnostic code previously did.